Don't crash on startup when version cache dir is unwritable#5452
Open
ikatyal2110 wants to merge 2 commits into
Open
Don't crash on startup when version cache dir is unwritable#5452ikatyal2110 wants to merge 2 commits into
ikatyal2110 wants to merge 2 commits into
Conversation
|
|
ikatyal2110
force-pushed
the
fix-versioncheck-permission-error
branch
from
July 13, 2026 22:31
2e1d899 to
ace460f
Compare
|
Nice, straightforward implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When aider starts in an environment where Path.home() resolves to an unwritable path (e.g. / in certain containers or WSL configs), the mkdir and touch calls in the finally block of check_version() raise PermissionError, crashing startup before the user can do anything. The fix wraps those two lines in a try/except OSError so a bad home directory silently skips the cache write instead of aborting. Fixes #2865.