fix(ui): fix button alignment#10285
Conversation
notjaywu
commented
Jul 22, 2026
| before | after |
|---|---|
![]() |
![]() |
f38fd5c to
2ed0598
Compare
✅ Circular References ReportGenerated at: 2026-07-22T09:49:36.899Z Summary
Click to view all circular references in PR (9)Click to view all circular references in base branch (9)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
There was a problem hiding this comment.
⚠️ Not ready to approve
The new gap-2 spacing on vault buttons conflicts with existing space-left tooltip margin, likely causing unintended extra spacing and undermining the alignment fix.
Pull request overview
This PR adjusts settings-page button layout to improve vertical/horizontal alignment, primarily by switching certain rows/buttons to size-to-content and using flex alignment utilities.
Changes:
- Update Vault Key settings CTAs to use
form-row--startandwidth-autoso the buttons size to content rather than stretching full width. - Normalize Vault Key button inner layout with flex
justify-centerandgap-2, including a simplified loading spinner element. - Align the “Clear OAuth 2 session” button contents by making the button a flex container with centered alignment.
File summaries
| File | Description |
|---|---|
| packages/insomnia/src/ui/components/settings/vault-key-panel.tsx | Updates vault CTA row and button classes to size-to-content and align spinner/text/tooltip consistently. |
| packages/insomnia/src/ui/components/settings/general.tsx | Adjusts the “Clear OAuth 2 session” button to use flex centering for better alignment in the Security settings row. |
Review details
Comments suppressed due to low confidence (1)
packages/insomnia/src/ui/components/settings/vault-key-panel.tsx:212
- This Button also uses
gap-2, soHelpTooltip className="space-left"will double-apply spacing (gap + margin-left). Droppingspace-leftshould keep consistent spacing handled solely by the flex gap.
className="btn btn--outlined btn--super-compact width-auto flex items-center justify-center gap-2"
onPress={() => setShowModal(true)}
>
Enter Vault Key
<HelpTooltip className="space-left">Enter your vault key to unlock all local secrets.</HelpTooltip>
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Pull request was converted to draft

