Add Embedded Art support to fetchart plugin#6829
Open
overhacked wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6829 +/- ##
==========================================
- Coverage 74.92% 74.89% -0.04%
==========================================
Files 163 163
Lines 21174 21211 +37
Branches 3341 3347 +6
==========================================
+ Hits 15864 15885 +21
- Misses 4544 4557 +13
- Partials 766 769 +3
🚀 New features to boost your workflow:
|
overhacked
marked this pull request as draft
July 13, 2026 00:14
Contributor
Author
|
Taking this to draft to do a little work to improve the test coverage. |
overhacked
force-pushed
the
overhacked/fetchart_embedded
branch
from
July 14, 2026 18:00
02b1a4f to
18cd2e7
Compare
Add `embedded` source to extract embedded art from files. Add `skip_embedded` option to detect embedded art and skip fetching from other sources (if extracting isn't the desired end state). If `skip_embedded=yes`, then files with embedded art are considered "done" and skipped by FetchArt. If the `embedded` source is enabled, then embedded artwork is always extracted. The two settings are independent of each other. Fix variable shadowing lint due to added import of `_utils.art`. Signed-off-by: Ross Williams <ross@ross-williams.net>
Add unit tests for Embedded source of FetchArt plugin. Add integration tests for FetchArt plugin's handling of files with embedded artwork. Signed-off-by: Ross Williams <ross@ross-williams.net>
Signed-off-by: Ross Williams <ross@ross-williams.net>
Two messages were emitted in the lowest-level helper functions, which meant that callers who expected a silent pass/fail result to validate whether art is contained in media files would spam the CLI with info-level messages. This commit moves the emission-site of the log messages one level up the call stack so that the messages are only emitted by a function that is called when the user requests that art is extracted and needs success/skip/failure logged to the CLI. Also add art extraction logging to fetchart. Signed-off-by: Ross Williams <ross@ross-williams.net>
overhacked
force-pushed
the
overhacked/fetchart_embedded
branch
from
July 15, 2026 13:25
18cd2e7 to
aac06ee
Compare
overhacked
marked this pull request as ready for review
July 15, 2026 13:25
Contributor
Author
|
@snejus, this is ready whenever you have time to take a look. There are some test coverage places I'd like to address, but when investigating I found that more test harness refactoring around when plugins read their configuration (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
embeddedsource to extract embedded art from files. Addskip_embeddedoption to detect embedded art and skip fetching from other sources (if extracting isn't the desired end state).If
skip_embedded=yes, then files with embedded art are considered "done" and skipped by FetchArt. If theembeddedsource is enabled, then embedded artwork is always extracted. The two settings are independent of each other.Fixes #1130.
To Do