Skip to content

tests: deflake TestCompactionHash#22151

Open
Aijeyomah wants to merge 1 commit into
etcd-io:mainfrom
Aijeyomah:fix-21980-compaction-hash-flake
Open

tests: deflake TestCompactionHash#22151
Aijeyomah wants to merge 1 commit into
etcd-io:mainfrom
Aijeyomah:fix-21980-compaction-hash-flake

Conversation

@Aijeyomah

Copy link
Copy Markdown

Fixes #21980

  • Made TestCompactionHash wait for compaction to finish before continuing, removing the timing-related flake.

Testing:

go test -race ./tests/integration/clientv3 \
  -run '^TestCompactionHash$' \
  -count=10 \
  -cpu=4 \
  -failfast \
  -timeout=30m

Test Result

Screenshot 2026-07-21 at 23 08 52

Wait for physical compaction to complete instead of relying on a fixed sleep, which may expire before scheduled compaction finishes.

Fixes etcd-io#21980

Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aijeyomah
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown

Hi @Aijeyomah. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Flaky TestCompactionHash

1 participant