rust: re-export ModelPolicyState and ModelPickerCategory from crate root#2051
Open
rinceyuan wants to merge 1 commit into
Open
rust: re-export ModelPolicyState and ModelPickerCategory from crate root#2051rinceyuan wants to merge 1 commit into
rinceyuan wants to merge 1 commit into
Conversation
Closes github#1674 Add ModelPickerCategory and ModelPolicyState to the curated pub use block in types.rs. These enums are field types of Model and ModelPolicy which are already re-exported, but the enums themselves required importing from copilot::rpc.
Contributor
Author
|
@microsoft-github-policy-service agree company=Microsoft |
Contributor
Author
|
@stephentoub Tiny consistency fix — 2 missing enum re-exports for types whose parent structs are already at the crate root. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1674
\ModelPolicy\ and \Model\ are re-exported at the crate root, but their field-type enums \ModelPolicyState\ and \ModelPickerCategory\ are not. This forces consumers to reach into \copilot::rpc\ for types that logically belong alongside the already-exported structs.
This adds both enums to the curated \pub use\ block in \ ypes.rs, in alphabetical order.