Skip to content

v8: report minor mark-sweep in GCProfiler#64688

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:v8gc
Open

v8: report minor mark-sweep in GCProfiler#64688
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:v8gc

Conversation

@Archkon

@Archkon Archkon commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Fixes: #64687

@Archkon
v8: report minor mark-sweep in GCProfiler
7c00c04 
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 23, 2026
@codecov

codecov Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (0992f6b) to head (7c00c04).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64688      +/-   ##
==========================================
- Coverage   90.14%   90.12%   -0.02%     
==========================================
  Files         741      741              
  Lines      242112   242113       +1     
  Branches    45605    45601       -4     
==========================================
- Hits       218244   218211      -33     
- Misses      15360    15393      +33     
- Partials     8508     8509       +1
Files with missing lines Coverage Δ
src/node_v8.cc 88.31% <100.00%> (+0.02%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334 Renegade334 added v8 module Issues and PRs related to the "v8" subsystem. and removed v8 engine Issues and PRs related to the V8 dependency. labels Jul 23, 2026
Renegade334
Renegade334 approved these changes Jul 23, 2026
View reviewed changes

@Renegade334 Renegade334 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75069/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@Renegade334 Renegade334 Renegade334 approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v8 module Issues and PRs related to the "v8" subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v8: GCProfiler reports minor mark-sweep collections as "Unknown"

4 participants

@Archkon @nodejs-github-bot @lpinca @Renegade334