fix(tag): handle scalar type_menu in massive updates#360
Open
rickserrat wants to merge 2 commits into
Open
Conversation
rickserrat
marked this pull request as ready for review
July 20, 2026 18:56
4 tasks
Rom1-B
self-requested a review
July 24, 2026 10:36
Rom1-B
requested changes
Jul 24, 2026
Rom1-B
left a comment
Contributor
There was a problem hiding this comment.
Functionally, it seems OK.
Can you rebase to resolve the conflicts
and then fix the lint issues?
rickserrat
force-pushed
the
fix/massive-update-type-menu
branch
from
July 24, 2026 11:58
007d0cf to
dd5c55c
Compare
Author
Thanks for the review. I rebased the branch onto the latest main, resolved the conflicts, and fixed the PHP-CS-Fixer, Rector, and licence header issues. The test was merged into the existing TagTest class and the test suite passes. |
Rom1-B
requested changes
Jul 24, 2026
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
TypeErrorwhen updating tag associated item types through GLPI massive actions.type_menuvalues into an array before callingarray_values()and encoding the value as JSON.type_menuis already an array.type_menuis provided as a scalar string.Testing
TagTest::testUpdateAcceptsScalarTypeMenu().Screenshots
Not applicable. This is a backend error handling fix.