feat(transfer): add secure SSE-C source and destination keys#307
Merged
Conversation
Member
Author
|
Final validation summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rustfs/backlog#1459.
Background
SSE-C transfers require a 256-bit customer key on every relevant S3 request. Accepting that key literally on the command line or allowing it into diagnostics would expose sensitive material, while sending it over an untrusted transport would disclose the derived header value on the wire.
Root cause
The transfer adapter modeled SSE-C keys but the CLI had no secure file/environment input path, and the RustFS S3 adapter still rejected SSE-C writes and reads. Multipart, planner metadata reads, checksum verification, and pinned compatibility tests also lacked SSE-C propagation.
Solution
cpandpipe; require exactly 32 bytes, zeroizing storage, protected regular files, and redacted formatting/errorsalias set --ca-bundlefor verified private endpointsValidation
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacebash -n scripts/probe-rustfs-compatibility.shThe local Docker daemon was unavailable, so the pinned RustFS beta.10 TLS integration is delegated to the PR CI gate.