You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Exposes the uv lofile detection and FF check, so we can consume this in cli-extension-os-flows and don't have to leave the low-level, uv-specific code there. Addendum to #165.
The IsUvProject function hardcodes a nil logger when calling HasLockFile. In the previous implementation within callback.go (see old hunk), HasLockFile was passed a valid *zerolog.Logger. This change silences diagnostic logs during the project detection phase, which are critical for debugging why a project might be skipped (e.g., permission issues or path mismatches). Furthermore, if HasLockFile is not defensive against nil loggers, this will cause a panic at runtime.
The test defines a local constant featureFlagUvCLI with a hardcoded string value instead of importing and using workflow.FeatureFlagUvCLI from internal/workflow. Since detection.go relies on the internal/workflow constant, any future change to that constant's value would result in tests passing while the production code fails to detect the flag correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Exposes the uv lofile detection and FF check, so we can consume this in cli-extension-os-flows and don't have to leave the low-level, uv-specific code there. Addendum to #165.