Skip to content

feat: add @stdlib/math/base/special/besselj1f#13627

Open
ujjwalv01 wants to merge 4 commits into
stdlib-js:developfrom
ujjwalv01:feat-add-besselj1f
Open

feat: add @stdlib/math/base/special/besselj1f#13627
ujjwalv01 wants to merge 4 commits into
stdlib-js:developfrom
ujjwalv01:feat-add-besselj1f

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Resolves a part of #649.

Description

What is the purpose of this pull request?

  • introduces the @stdlib/math/base/special/besselj1f package, which computes the Bessel function of the first kind of order one for a single-precision floating-point number.
  • creates the standard package structure including JS implementations, Native C addons (addon.c, main.c), Type definitions, Benchmarks, and Tests.
  • implements the initial C wrapper (src/main.c) by following the established wrapper pattern to wrap the double-precision stdlib_base_besselj1( x ) and cast the output to a float.
  • adapts the existing comprehensive Julia test fixtures for single-precision by converting inputs and expected values to float32 during test execution, maintaining rigorous precision checks.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted an AI assistant to help me adapt the tests and benchmarks for single-precision functionality based on the existing double-precision besselj1 package structure.


@stdlib-js/reviewers

@ujjwalv01
ujjwalv01 requested a review from a team July 23, 2026 13:08
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jul 23, 2026
@ujjwalv01 ujjwalv01 changed the title Feat add besselj1f feat: add @stdlib/math/base/special/besselj1f Jul 23, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/besselj1f $\\color{green}169/169$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}169/169$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants